Skip to content

feat: add Halkomelem APA/Hul’q’umi’num’ mapping#413

Merged
roedoejet merged 1 commit intoNRC-ILT:mainfrom
goodzack:main
Jan 17, 2025
Merged

feat: add Halkomelem APA/Hul’q’umi’num’ mapping#413
roedoejet merged 1 commit intoNRC-ILT:mainfrom
goodzack:main

Conversation

@goodzack
Copy link
Copy Markdown
Contributor

@goodzack goodzack commented Jan 9, 2025

Hul’q‛umi’num’ is the Island dialect of Halkomelem. This mapping is between APA used to transcribe Salish languages and the Hul’q’umi’num’ practical orthography.

Pull request template for adding a new language

  • Please check if the PR fulfills these requirements
  • [x ] Mapping files are added in g2p/mappings/langs
  • [x ] Mapping is either added to an existing folder or a new folder has been added
  • [x ] Language folder and files use appropriate ISO 639-3 codes
  • [x ] config-g2p.yaml file includes all author names, and settings necessary
  • [x ] Please add some test data in g2p/tests/public/data. The added file should be a csv/tsv/psv file and each row should have the format [input_mapping_code,output_mapping_code,input_string,output_string]
  • [x ] As the last step, G2P has been updated by running g2p update locally and committing the change
  • [x ] You agree to license your contribution under the same license as this project (see LICENSE file).
  • Other information:
    Cheers 😛

@goodzack
feat: add Halkomelem APA/Hul’q’umi’num’ mapping
9dbd466 
Hul’q‛umi’num’ is the Island dialect of Halkomelem.
This mapping is between APA used to transcribe Salish languages
and the Hul’q’umi’num’ practical orthography.
@roedoejet
Copy link
Copy Markdown
Collaborator

roedoejet commented Jan 9, 2025

Hul’q‛umi’num’ is the Island dialect of Halkomelem. This mapping is between APA used to transcribe Salish languages and the Hul’q’umi’num’ practical orthography.

Pull request template for adding a new language

  • Please check if the PR fulfills these requirements

  • [x ] Mapping files are added in g2p/mappings/langs

  • [x ] Mapping is either added to an existing folder or a new folder has been added

  • [x ] Language folder and files use appropriate ISO 639-3 codes

  • [x ] config-g2p.yaml file includes all author names, and settings necessary

  • [x ] Please add some test data in g2p/tests/public/data. The added file should be a csv/tsv/psv file and each row should have the format [input_mapping_code,output_mapping_code,input_string,output_string]

  • [x ] As the last step, G2P has been updated by running g2p update locally and committing the change

  • [x ] You agree to license your contribution under the same license as this project (see LICENSE file).

  • Other information:
    Cheers 😛

Very very cool! We'll have a look at this soon, thanks @goodzack !

@roedoejet roedoejet requested review from joanise and roedoejet January 9, 2025 22:00
roedoejet
roedoejet approved these changes Jan 17, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@roedoejet roedoejet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome @goodzack - thanks so much! We'll merge this in, but just FYI, I made a few changes here: I changed hur_orthog to just hur since the plain ISO code is typically just the orthographic form for other mappings. I also changed hur_apa to hur-apa for continuity with our other mappings. Thanks so much.

@roedoejet roedoejet merged commit 9dbd466 into NRC-ILT:main Jan 17, 2025
@roedoejet
Copy link
Copy Markdown
Collaborator

roedoejet commented Jan 17, 2025

The mapping is live now on https://g2p-studio.herokuapp.com/ and will be included in our next release. If you need this urgently in the package for some reason let me know and we can release a patch (v2.2.1) with the mapping

image

@joanise joanise mentioned this pull request Jan 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roedoejet roedoejet roedoejet approved these changes

@joanise joanise Awaiting requested review from joanise

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@goodzack @roedoejet